10 replies to this topic

[cathode]

I just noticed that uploading images from within the Xinha editor renames images with dashes - making them underscores. Has anyone else noticed this? It's hard to believe I haven't run into this before...

[darren]

I just noticed that uploading images from within the Xinha editor renames images with dashes - making them underscores. Has anyone else noticed this? It's hard to believe I haven't run into this before...

never noticed, but yeah it does for me too... that could potentially make managing images confusing. I use the file manager, the Xinha image manager, and other software (dreamweaver, filezilla) to upload files so i'll have to keep a close eye on local vs remote image names.

thanks for bringing this up.

[Ralph]

I've never noticed but, then again, I rarely upload through Xinha with hyphens either... I wonder if their site has info on this functionality...

[cathode]

never noticed, but yeah it does for me too... that could potentially make managing images confusing. I use the file manager, the Xinha image manager, and other software (dreamweaver, filezilla) to upload files so i'll have to keep a close eye on local vs remote image names.

thanks for bringing this up.

Thanks for confirming this, Darren!

[darren]

In here?
line 86, xinha/plugins/ImageManager/Classes/Files.php


[codebox]/**
* Escape the filenames, any non-word characters will be
* replaced by an underscore.
* @param string $filename the orginal filename
* @return string the escaped safe filename
*/
function escape($filename)
{
Return preg_replace('/[^\w\._]/', '_', $filename);
}[/codebox]

[cathode]

In here?
line 86, xinha/plugins/ImageManager/Classes/Files.php

/**	 * Escape the filenames, any non-word characters will be	 * replaced by an underscore.	 * @param string $filename the orginal filename	 * @return string the escaped safe filename	 */	function escape($filename) 	{		Return preg_replace('/[^\w\._]/', '_', $filename);	}

That looks like it may be it, I don't know enough to decode that preg_replace line, Ralph, can you see a way to make that not change dashes to underscores?

[darren]

yeah, i don't see hyphens in there..

[Cris D.]

Old
Return preg_replace('/[^\w\._]/', '_', $filename);


the carrot "^" means "except"...

New
Return preg_replace('/[^\w\._-]/', '_', $filename);

But I'm not sure of the full consequences with the xinha code for doing this...

[Ralph]

I really don't think there would be any implications in leaving hyphens in filenames... As far as I know all OS's and servers allow hyphens... Perhaps it was merely an oversight by the person who wrote that piece of code...

[darren]

the carrot "^" means "except"...

well i learned something new today, time to turn in.

thanks Cris.

[cathode]

Awesome- I learned something too- Thanks guys! I'll be trying this out.