4 replies to this topic

[traderhut]

Hi,

I made the following change to the Index.php, in the end of the routine PutIntTableRow()


$sql = "INSERT INTO $tbl SET ";
foreach($fields as $key=>$value) {
$sql .= "`".$key."`=";
if ($value == null) $sql .= 'null,';
else
if (is_numeric($value)) $sql .= $value.",";
else $sql .= "'".$value."',";
}


Perhaps, there is another way to handle this, but looking at the code, I don't see one.. I wanted to set a column to the value null, however, the code will attempt to set it to '', which MySQL isn't taking as null. (Oracle does, which drives me nuts, but that is another topic)


This change allows the value to be set as:


$values= array(
'CubeID' => $CubeID,
'GroupDescription' => $GroupName,
'created_at' => null
);

$etomite->putIntTableRow($values, "Cubes");

Allowing a column that is a timestamp to be updated to the current time, which can not be done on the SQL Server (if you also have a On Update timestamp column)

(I'm guessing the same change should be added to the update code, as well as code for External tables/db)

-Chert

PS: Last I heard there was active development on etomite. Would said developers be interested in my helping develop? I hate to have "my own version" of the source, Or even a set of patches that I'll have to apply when the next version comes out... (I'd be interested to know if/when this gets put into the main line, so I know I won't have to worry about it in the future...)

---
Runecube.Com

[Ralph]

I'm sure there is room for improvement for the putIntTableRow() and putExtTableRow() functions... They have worked within expectations for my custom coding needs as I use the get functions far more often than the put functions... If the data is properly validated prior to saving there shouldn't be any problems, however...

[traderhut]

I'm sure there is room for improvement for the putIntTableRow() and putExtTableRow() functions... They have worked within expectations for my custom coding needs as I use the get functions far more often than the put functions... If the data is properly validated prior to saving there shouldn't be any problems, however...

It isn't a matter of properly validated. Try to set a field to null using the PutIntTableRow() function. You can't, unless you add the change that I made.

-Chert

[Ralph]

It isn't a matter of properly validated. Try to set a field to null using the PutIntTableRow() function. You can't, unless you add the change that I made.

-Chert

I'll have to look into this as the code base should already have code to account for both strings and numerics...

Which release are you working with...???

[traderhut]

I'll have to look into this as the code base should already have code to account for both strings and numerics...

Which release are you working with...???

The latest, And yes, it handles strings and numerics... Strings have ' s around them.. .I.E. 'Null' and Numerics are passed in as the numeric value.. 0... but if the value is NULL, then you wan to just pass null to the SQL.

See the code posted, all I did was add a simple check for the value being null before doing the other check. It's a one-line-er change, but useful if you need to store NULL into a database field.

-Chert